Fixed #9121 - Auto scrolling (i.e. scroll:true) with Sortable/Draggable hasn't worked since jquery-ui 1.8.24 powered by jQuery 1.8.2 #933
Conversation
…fsetHeight is less than .height(). Fixed #9121 - Auto scrolling (i.e. scroll:true) with Sortable/Draggable hasn't worked since jquery-ui 1.8.24 powered by jQuery 1.8.2
|
Thanks for contributing, @dcarrith! I imagine your document is in Quirks mode. If you use |
|
Hi @mikesherov - You're welcome and thanks for the tip. However, I do have in place. Furthermore, this issue is not just an IE issue as is suggested in issue #7546 (http://bugs.jqueryui.com/ticket/7546). It's happening for me in Safari, Chrome and Firefox on OSX 10.8.2. The "fix" I committed here fixes it in Chrome and Firefox, but not Safari. I'm going to experiment with the "position: relative" since that seems to fix it for IE according to comment #6 on issue #7546. Maybe it would fix it for Safari too. That would be ironic. |
|
@dcarrith, sorry about closing this early, and thanks for the hard work. In order to land any change for this, what we'll need is proof this fixes the issue in all of our supported browsers: a unit test based off the jsfiddle in the ticket, and you'll also need to sign our CLA: http://contribute.jquery.org/CLA/ Please open a new pull request after you figure out fixes in IE and safari for this. Thanks again! |
Added additional check to make sure this.scrollParent[0].offsetHeight is less than $(window).height().